Change in vdsm[master]: virt: stats: move dynamic stats in a method

fromani at redhat.com fromani at redhat.com
Mon Apr 28 06:34:18 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: virt: stats: move dynamic stats in a method
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/26548/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2483:         stats['exitReason'] = self.conf['exitReason']
Line 2484:         if 'timeOffset' in self.conf:
Line 2485:             stats['timeOffset'] = self.conf['timeOffset']
Line 2486: 
Line 2487:     def _addDynamicVmStats(self, stats):
> the juridcition of this method is not very clear, but I do not mind making 
The intended purpose was to add to the stats output all the fields provided by the VmStatsThread; compare for example with the fields which are copied by the Vm.conf dict ("static" stats? "core" stats?) or from the guest agent return data.

Maybe renaming this method will make it a bit more understandable?
Line 2488:         decStats = {}
Line 2489:         try:
Line 2490:             if self._vmStats:
Line 2491:                 decStats = self._vmStats.get()


-- 
To view, visit http://gerrit.ovirt.org/26548
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5a2b7658c209a3dcdd6df46052440204ad52a5d3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list