Change in vdsm[master]: virt: graphdev: introduce the GraphicsDevice class

fromani at redhat.com fromani at redhat.com
Mon Apr 28 06:25:57 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: virt: graphdev: introduce the GraphicsDevice class
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.ovirt.org/#/c/26894/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 1379:     LIBVIRT_PORT_AUTOSELECT = '-1'
Line 1380: 
Line 1381:     @staticmethod
Line 1382:     def isSupportedDisplayType(vmParams):
Line 1383:         return vmParams.get('display') in ('vnc', 'qxl', 'qxlnc')
> didn't you tell Michal you'd need to add "spice" to the tuple? or is it exp
Yes I did. At first I thought it was simple enough to have it in the current patcheset; while adding it I changed my mind and I think it will be better if we leave this for a follow up patch, in order to let simplify a bit this patchset.
Line 1384: 
Line 1385:     @staticmethod
Line 1386:     def adjustDisplayParams(dispParams, displayIp):
Line 1387:         """


-- 
To view, visit http://gerrit.ovirt.org/26894
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4f8e527fd48d8635b61cdc14eed31b8992e4f6c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list