Change in vdsm[master]: sp: fix spm start when failing to produce domain

danken at redhat.com danken at redhat.com
Sun Apr 27 16:51:14 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: sp: fix spm start when failing to produce domain
......................................................................


Patch Set 1: Code-Review-1

I share your opinion: we should also handle the case where produce() succeeded (e.g. since the domain is already cached) and but the metadata-changing operation failed due to timeout. However, we should not blindly ignore all failures.

Process wise, this changes should keep http://gerrit.ovirt.org/25424 's Change-Id, in order to retain all the history of the change. We shall handle Eduardo's -2 heads-on.

-- 
To view, visit http://gerrit.ovirt.org/27118
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0d30bc653e3282f2de3dfdc18fadd03cdf42bbb1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list