Change in vdsm[master]: sp: fix spm start when failing to produce domain

laravot at redhat.com laravot at redhat.com
Sun Apr 27 15:17:24 UTC 2014


Liron Ar has posted comments on this change.

Change subject: sp: fix spm start when failing to produce domain
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/27118/1/vdsm/storage/sp.py
File vdsm/storage/sp.py:

Line 207:                 if domain.getDomainRole() == sd.REGULAR_DOMAIN:
Line 208:                     continue
Line 209: 
Line 210:                 self._backend.setDomainRegularRole(domain)
Line 211:             except se.StorageDomainDoesNotExist:
I believe that we should ignore any (storage) exception to avoid the same case in
different scenarios (for example - failure to alter the metadata), but
as reviewers requested, let's start with StorageDomainDoesNotExist
exception only.
Line 212:                 self.log.error("Error when trying to find domain %s, ignoring",
Line 213:                                sdUUID, exc_info=True)
Line 214: 
Line 215:     @unsecured


-- 
To view, visit http://gerrit.ovirt.org/27118
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0d30bc653e3282f2de3dfdc18fadd03cdf42bbb1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list