Change in vdsm[master]: hooks: Add hook for fake VM stats

danken at redhat.com danken at redhat.com
Sun Apr 27 13:36:18 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: hooks: Add hook for fake VM stats
......................................................................


Patch Set 12:

(1 comment)

http://gerrit.ovirt.org/#/c/25927/12/vdsm/API.py
File vdsm/API.py:

Line 1201:         """
Line 1202:         vms = self.getVMList()
Line 1203:         statsList = []
Line 1204:         for s in vms['vmList']:
Line 1205:             response = VM(s['vmId']).getStats()
> Dan,
Leaving this "as is" does not let the hook builder any choice but to report non-consistent values. Even if they want to, their getAllVmStats() would differ from the relevant getSingleVmStats().

Please add an additional hookpoint for the the single VM case, so that a user that cares about consistency more than performance could be using?

If no before_get_vm_stats script exists, you loose nothing.
Line 1206:             if response:
Line 1207:                 statsList.append(response['statsList'][0])
Line 1208:         statsList = hooks.after_get_all_vm_stats(statsList)
Line 1209:         return {'status': doneCode, 'statsList': statsList}


-- 
To view, visit http://gerrit.ovirt.org/25927
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a6d13f43495170a5cb86ae0b0efc1ae85ef05ab
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list