Change in vdsm[master]: virt: stats: move exited vm stats in a method

danken at redhat.com danken at redhat.com
Sat Apr 26 15:30:17 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: virt: stats: move exited vm stats in a method
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/26547/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2498:         if self.isMigrating():
Line 2499:             stats['migrationProgress'] = self.migrateStatus()['progress']
Line 2500:         return stats
Line 2501: 
Line 2502:     def _addExitedVmStats(self, stats):
this function (and its caller) can be simpler to understand if it simply returned the stats, and not change its argument.
Line 2503:         stats['exitCode'] = self.conf['exitCode']
Line 2504:         stats['status'] = self.lastStatus
Line 2505:         stats['exitMessage'] = self.conf['exitMessage']
Line 2506:         stats['exitReason'] = self.conf['exitReason']


-- 
To view, visit http://gerrit.ovirt.org/26547
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7492086bfc7ce02b6f7035fef8d04fbc0b7fbc43
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list