Change in vdsm[master]: LiveMerge: Add support for deleting merged volumes

Federico Simoncelli fsimonce at redhat.com
Thu Apr 24 17:14:32 UTC 2014


Federico Simoncelli has posted comments on this change.

Change subject: LiveMerge: Add support for deleting merged volumes
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/26768/2/vdsm/storage/blockVolume.py
File vdsm/storage/blockVolume.py:

Line 229:             if puuid and puuid != volume.BLANK_UUID:
Line 230:                 pvol = BlockVolume(self.repoPath, self.sdUUID, self.imgUUID,
Line 231:                                    puuid)
Line 232:                 # If this volume has a child (ie. after live merge), set the
Line 233:                 # child volume's parent to this volume's parent.
We need a specific comment about why this is needed for block (but eventually not for file) domains.
Line 234:                 if not self.isLeaf():
Line 235:                     child = self.getChildren()[0]
Line 236:                     BlockVolume(self.repoPath, self.sdUUID, self.imgUUID,
Line 237:                                 child).setParent(puuid)


-- 
To view, visit http://gerrit.ovirt.org/26768
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf43f65f984d7f76622454dc8877d56ef8dedb8f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list