Change in vdsm[master]: unified_persistence: Fix defaultRoute type in upgrade script

danken at redhat.com danken at redhat.com
Thu Apr 24 16:27:28 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: unified_persistence: Fix defaultRoute type in upgrade script
......................................................................


unified_persistence: Fix defaultRoute type in upgrade script

Despite the fact defaultRoute is defined by vdsm API to be a boolean
field, the upgrade to unified persistence script was retrieving it
as a string. This had the effect that when the ifcfg configurator
would convert from boolean to 'yes'/'no', both 'True' and 'False',
being strings would evaluate as True.

Change-Id: I0f468bed70fcb3e2af46944f10ef47eecb1c0e94
Signed-off-by: Antoni S. Puimedon <asegurap at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/27021
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/tool/unified_persistence.py
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Antoni Segura Puimedon: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/27021
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0f468bed70fcb3e2af46944f10ef47eecb1c0e94
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list