Change in vdsm[master]: call stop_event_loop upon exit

nsoffer at redhat.com nsoffer at redhat.com
Wed Apr 23 15:05:34 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: call stop_event_loop upon exit
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/26532/2/vdsm/vdsm
File vdsm/vdsm:

Line 83:         finally:
Line 84:             cif.prepareForShutdown()
Line 85: 
Line 86:     finally:
Line 87:         libvirtconnection.stop_event_loop()
If libvirt.virEventRunDefaultImpl() is blocking waiting for events, stop_event_loop() will block, leading to killing of vdsm and not waiting for other threads in run().

So it seems that async version, stop_event_loop(False) is better here.
Line 88: 
Line 89: 
Line 90: def run(pidfile=None):
Line 91:     lconfig.fileConfig(loggerConfFile, disable_existing_loggers=False)


-- 
To view, visit http://gerrit.ovirt.org/26532
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9ab0d9b7be976e37a89a96d2f09a353186008731
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list