Change in vdsm[master]: ethtool_opts: Add hook for applying network custom property

asegurap at redhat.com asegurap at redhat.com
Wed Apr 23 11:00:02 UTC 2014


Antoni Segura Puimedon has posted comments on this change.

Change subject: ethtool_opts: Add hook for applying network custom property
......................................................................


Patch Set 3:

I improved the output of the testing and fixed one of the test features name (tso).

The verification process consisted on:

    toniel602 ~ # ethtool --show-offload eth2                  
    Features for eth2:
    rx-checksumming: on
    tx-checksumming: on
    scatter-gather: on
    tcp-segmentation-offload: on
    udp-fragmentation-offload: on
    generic-segmentation-offload: on
    generic-receive-offload: off
    large-receive-offload: off
    ntuple-filters: off
    receive-hashing: off

On a python terminal:
    from vdsm import vdscli


    c = vdscli.connect()

    # Changing tcp-segmentation-offload for eht2
    c.setupNetworks({'ethopt':
                     {'nic': 'eth2',
                      'custom':
                      {'ethtool_opts':
                       '--offload eth2 tso off'}}
                     }, {}, {'connectivityCheck': False})

back to bash:
    toniel602 ~ # ethtool --show-offload eth2
    Features for eth2:
    rx-checksumming: on
    tx-checksumming: on
    scatter-gather: on
    tcp-segmentation-offload: off
    udp-fragmentation-offload: on
    generic-segmentation-offload: on
    generic-receive-offload: off
    large-receive-offload: off
    ntuple-filters: off
    receive-hashing: off
    toniel602 ~ #

-- 
To view, visit http://gerrit.ovirt.org/26694
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I41d89e00002e2b011bc1dc2825276d14bc99f577
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list