Change in vdsm[master]: vdsm-reg-setup: use os.errno.EEXIST

danken at redhat.com danken at redhat.com
Wed Apr 23 08:47:33 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: vdsm-reg-setup: use os.errno.EEXIST
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/26994/1/vdsm_reg/vdsm-reg-setup.in
File vdsm_reg/vdsm-reg-setup.in:

Line 221:         try:
Line 222:             os.makedirs(upgradeDir)
Line 223:             os.chmod(upgradeDir, 0o755)
Line 224:         except OSError as err:
Line 225:             if err.errno != os.errno.EEXIST:
better import "errno" explicitly, then rely on the inadvertent existence of "errno" in os. Please add vdsm_reg/vdsm-reg-setup.in to pyflakes so that something like that would not repeat.
Line 226:                 logging.error(
Line 227:                     "can not create vdsm upgrade dir: %s" % upgradeDir
Line 228:                 )
Line 229: 


-- 
To view, visit http://gerrit.ovirt.org/26994
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3d0836d060d2882b57d38e7299c3302312835f82
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list