Change in vdsm[master]: caps: Add selinux enforcement reporting.
dougsland at redhat.com
dougsland at redhat.com
Wed Apr 23 01:41:15 UTC 2014
Douglas Schilling Landgraf has posted comments on this change.
Change subject: caps: Add selinux enforcement reporting.
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/26951/1/vdsm/caps.py
File vdsm/caps.py:
Line 390: else:
Line 391: return platform.machine()
Line 392:
Line 393:
Line 394: def getSELinuxEnforceMode():
What about have this function available in /usr/<lib>/python-2.7/site-packages/vdsm/utils.py ? IMO, can fit there, not limiting the availability in caps.py. Before doing that, please consult others.
Line 395: selinux_mnts = ['/sys/fs/selinux', '/selinux']
Line 396: for mnt in selinux_mnts:
Line 397: enforce_path = os.path.join(mnt, 'enforce')
Line 398: if not os.path.exists(enforce_path):
--
To view, visit http://gerrit.ovirt.org/26951
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I98e0fcb71e831a76c4584bca46dc58fc4298180f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list