Change in vdsm[master]: Unknown dmidecode value is set to None which cannot be parse...
danken at redhat.com
danken at redhat.com
Tue Apr 22 12:03:00 UTC 2014
Dan Kenigsberg has posted comments on this change.
Change subject: Unknown dmidecode value is set to None which cannot be parsed by xmlrpc
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/26942/1/vdsm/dmidecodeUtil.py
File vdsm/dmidecodeUtil.py:
Line 31: for k, v in d.iteritems():
Line 32: if isinstance(v, dict):
Line 33: ret.update(__leafDict(v))
Line 34: else:
Line 35: if v is None:
It would be nicer to drop a missing key altogether, over reporting a false value. Can Engine handle that? If not, please explain that in the commit message.
Line 36: ret[k] = ''
Line 37: else:
Line 38: ret[k] = v
Line 39: return ret
--
To view, visit http://gerrit.ovirt.org/26942
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I979518e1d0c0c882fe98fd5aee43c0d50ab17e14
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list