Change in vdsm[master]: caps: Add selinux enforcement reporting.
ybronhei at redhat.com
ybronhei at redhat.com
Tue Apr 22 11:09:33 UTC 2014
Yaniv Bronhaim has posted comments on this change.
Change subject: caps: Add selinux enforcement reporting.
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.ovirt.org/#/c/26951/1//COMMIT_MSG
Commit Message:
Line 7: caps: Add selinux enforcement reporting.
Line 8:
Line 9: Added selinuxEnforceModed field to getVdsCaps() what indicates whether
Line 10: selinux is enforced on host or not
Line 11:
add direct link to engine's part
Line 12: Change-Id: I98e0fcb71e831a76c4584bca46dc58fc4298180f
http://gerrit.ovirt.org/#/c/26951/1/vdsm/caps.py
File vdsm/caps.py:
Line 405: -
I would add here the comment from /etc/selinux/config:
# 1= enforcing - SELinux security policy is enforced.
# 0 = permissive - SELinux prints warnings instead of enforcing.
# -1= disabled - No SELinux policy is loaded.
or use enums
Line 474: caps['numaNodeDistance'] = _getNumaNodeDistance()
Line 475: caps['autoNumaBalancing'] = _getAutoNumaBalancingInfo()
Line 476:
Line 477: if selinux.is_selinux_enabled() == 0:
Line 478: caps['selinuxEnforceMode'] = str(-1)
do we really need selinux package here? isn't getSELinuxEnforceMode enough for this purpose ?
Line 479: else:
Line 480: caps['selinuxEnforceMode'] = getSELinuxEnforceMode()
Line 481: return caps
Line 482:
--
To view, visit http://gerrit.ovirt.org/26951
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I98e0fcb71e831a76c4584bca46dc58fc4298180f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list