Change in vdsm[master]: virt: graphdev: add hasSpice helper

danken at redhat.com danken at redhat.com
Sat Apr 19 15:19:12 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: virt: graphdev: add hasSpice helper
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

http://gerrit.ovirt.org/#/c/26892/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 4199:             self.log.warning('unexpected action %i on device %s error %s',
Line 4200:                              action, blockDevAlias, err)
Line 4201: 
Line 4202:     @property
Line 4203:     def hasSpice(self):
I am not sure that a property is best here, but I do not really mind.
Line 4204:         return self.conf.get('display') == 'qxl'
Line 4205: 
Line 4206:     def _getPid(self):
Line 4207:         pid = '0'


-- 
To view, visit http://gerrit.ovirt.org/26892
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I170e439f54a16c2616b57533505ad65e8c06490f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list