Change in vdsm[master]: vdsm_config: move download certificate

Alon Bar-Lev alonbl at redhat.com
Sat Apr 19 07:41:30 UTC 2014


Alon Bar-Lev has posted comments on this change.

Change subject: vdsm_config: move download certificate
......................................................................


Patch Set 11:

(1 comment)

http://gerrit.ovirt.org/#/c/26718/11/vdsm_reg/vdsm-config
File vdsm_reg/vdsm-config:

Line 95: 					/etc/vdsm-reg/vdsm-reg.conf
Line 96: 			fi
Line 97: 
Line 98: 			if [ ! -z "$management_server_fingerprint" ]; then
Line 99: 				sed --copy -i "s/\(^fingerprint=\)\(..*$\)/\1${management_server_fingerprint}/" \
> Missing "fingerprint=" from autoinstall parameter? Then, user won't check f
1. I mean missing within the template, you must inject this parameter into configuration if the cmdline has fingerprint parameter.

2. --copy, well, ok... although much better to prepare single temporary file and then handle the persist part. not that important, we will drop this code soon anyway.
Line 100: 					/etc/vdsm-reg/vdsm-reg.conf
Line 101: 			fi
Line 102: 
Line 103: 			res=`python "$DEPLOY_UTIL" --node-cleanup`


-- 
To view, visit http://gerrit.ovirt.org/26718
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2c025eedd2be92b9418ddbe01efc02c913af2a7
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list