Change in vdsm[master]: dispatcher: use a method wrapper instead of Protect

Federico Simoncelli fsimonce at redhat.com
Fri Apr 18 16:07:59 UTC 2014


Federico Simoncelli has posted comments on this change.

Change subject: dispatcher: use a method wrapper instead of Protect
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.ovirt.org/#/c/26774/4/vdsm/storage/dispatcher.py
File vdsm/storage/dispatcher.py:

Line 44
Line 45
Line 46
Line 47
Line 48
> it would not be a horrible loss if xml-rpc's system.methodHelp is dropped, 
Well... I haven't managed to get system.methodHelp to work so I cannot verify my idea... but basically @wraps (line 65) is supposed to keep the __doc__ value.

I think that we lost system.methodHelp when we introduced the xmlrpc binding and API.py (there's some wrapping there as well).

Anyway I am ok to drop something that is not working :-) But I thought it could have been another patch. Should I improve the commit message? (mentioning @wraps etc.)


Line 87: 
Line 88:                     return se.generateResponse(e)
Line 89:             except:
Line 90:                 try:
Line 91:                     self.log.error(
> there's plenty room for more simplification in future patches.
I know :-)
Line 92:                         "Unhandled exception in run and protect: %s, "
Line 93:                         "args: %s ", self.name, args, exc_info=True)
Line 94:                 finally:
Line 95:                     return self.STATUS_ERROR.copy()


-- 
To view, visit http://gerrit.ovirt.org/26774
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7a1a2f88238cb4b845e62de0c1f12e462a4ae72
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list