Change in vdsm[master]: vm: Fix guest channel symlink creation handling

michal.skrivanek at redhat.com michal.skrivanek at redhat.com
Fri Apr 18 10:35:19 UTC 2014


Michal Skrivanek has posted comments on this change.

Change subject: vm: Fix guest channel symlink creation handling
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/26882/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2713:                     os.path.unlink(uuidPath)
Line 2714:                 try:
Line 2715:                     os.symlink(path, uuidPath)
Line 2716:                 except OSError:
Line 2717:                     # We swallow OSError exceptions here, we rather have no
> Actually this fix should prevent 'File Exists' errors. I am wondering if I 
I'm not sure here on recovery the concept of catching only the minimum required exception makes sense. We want to try and recover as much as we can ignoring *any* error (because we can't do anything)…so it's not helping here….for almost all lines of code during recovery we want to say on any exception "yeah, whatever, let's continue with recovery anyway"

So I'd say: log it - yes, but then swallow any exception in _updateAgentChannels() at domDependentInit() level
Line 2718:                     # connection to the guest agent than a broken VM instance
Line 2719:                     self.log.exception("Failed to make a agent channel "
Line 2720:                                        "symlink from %s -> %s for channel %s",
Line 2721:                                        path, uuidPath, name)


-- 
To view, visit http://gerrit.ovirt.org/26882
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24e5d8e7b7e338c683d4064585539444044bb77a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list