Change in vdsm[master]: tests: virt: add infrastructure to test getStats

danken at redhat.com danken at redhat.com
Thu Apr 17 15:17:55 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: tests: virt: add infrastructure to test getStats
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.ovirt.org/#/c/26536/2/tests/vmTests.py
File tests/vmTests.py:

Line 898:     vm._initVmStats()
Line 899:     try:
Line 900:         yield vm
Line 901:     finally:
Line 902:         if vm._vmStats:
you initialize this data member 4 lines above - why do you check it again?
Line 903:             vm._vmStats.stop()
Line 904: 
Line 905: 
Line 906: class TestVmStats(TestCaseBase):


Line 936:             # HACKs
Line 937:             'pauseCode': 'NOERR',
Line 938:         }
Line 939:         with FakeVM(vmParams) as fake:
Line 940:             with ensureVmStats(fake):
why is it required to have vmStats running at this stage? how can you be sure that the stats thread has already been schedule?


-- 
To view, visit http://gerrit.ovirt.org/26536
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I28154f54995e2ff9a94c5da6ee38eaa5ed7d9b6d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list