Change in vdsm[master]: core: Add boot time to the getVdsStats API

danken at redhat.com danken at redhat.com
Wed Apr 16 12:04:19 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: core: Add boot time to the getVdsStats API
......................................................................


Patch Set 14: Code-Review+1

(1 comment)

http://gerrit.ovirt.org/#/c/25877/14/vdsm/sampling.py
File vdsm/sampling.py:

Line 451:         # include it in the response.
Line 452:         try:
Line 453:             return getBootTime()
Line 454:         except (IOError, ValueError):
Line 455:             self._log.error('Failed to get boot time', exc_info=True)
We do have plenty log.error(..., exc_info=True) in this file, but I do not mind changing them all to exception() as Federico suggests - but in a follow-up patch.
Line 456:             return None
Line 457: 
Line 458:     def get(self):
Line 459:         stats = self._getInterfacesStats()


-- 
To view, visit http://gerrit.ovirt.org/25877
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I319e619cdaecac2f86d0154e3adbb3beda9c57d6
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list