Change in vdsm[master]: caps: Collect numa information

fromani at redhat.com fromani at redhat.com
Mon Apr 14 06:22:26 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: caps: Collect numa information
......................................................................


Patch Set 12: Code-Review+1

(1 comment)

http://gerrit.ovirt.org/#/c/23703/12/vdsm_api/vdsmapi-schema.json
File vdsm_api/vdsmapi-schema.json:

Line 975: # @UNKNOWN:    Can't get the status(maybe not support in this kernel version)
Line 976: #
Line 977: # Since: 4.15.0
Line 978: ##
Line 979: {'enum': 'AutoNumaBalancingStatus', 'data': ['DISABLE', 'ENABLE', 'UNKNOWN']}
My personal taste is to use lowercase or Capitalized, but I see there are some enums ALL UPPERCASE (HaMaintenanceMode being the first example), so I think it is good enough.
Line 980: 
Line 981: ##
Line 982: # @HookScriptInfoMap:
Line 983: #


-- 
To view, visit http://gerrit.ovirt.org/23703
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I63eeb697ab986c3b9cad0dc44f41924f329e52cd
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi at hp.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa at eldorado.org.br>
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi at eldorado.org.br>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vitor de Lima <vitor.lima at eldorado.org.br>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi at hp.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list