Change in vdsm[master]: recovery: try to restore VMs from recovery files

michal.skrivanek at redhat.com michal.skrivanek at redhat.com
Fri Apr 11 10:03:02 UTC 2014


Michal Skrivanek has posted comments on this change.

Change subject: recovery: try to restore VMs from recovery files
......................................................................


Patch Set 9:

(3 comments)

http://gerrit.ovirt.org/#/c/25276/9/tests/functional/virtTests.py
File tests/functional/virtTests.py:

Line 192:             self.assertEquals(result['status'], vmstatus.UP)
Line 193: 
Line 194:     def _waitForBoot(self, vmid):
Line 195:         self.retryAssert(partial(self.assertQemuSetupComplete, vmid),
Line 196:                          timeout=10)
since we retry I wouldn't be afraid to increase these to something working on slow jenkins slaves…60 maybe?
Line 197:         self.retryAssert(partial(self.assertVmBooting, vmid),
Line 198:                          timeout=3)
Line 199:         self.retryAssert(partial(self.assertVmUp, vmid),
Line 200:                          timeout=10)


http://gerrit.ovirt.org/#/c/25276/9/tests/functional/vmRecoveryTests.py
File tests/functional/vmRecoveryTests.py:

Line 33: 
Line 34: from utils import SUCCESS
Line 35: 
Line 36: 
Line 37: def vdsm_start(wait_secs=5):
> We have ensure_vdsm_running, so why wait here
where did we ensure that?

in any case the startup needs enhancement. We should loop on getVdsCaps or something like that….probably in VsProxy initialization. Separate patch…mpoledni was working on something as well...
Line 38:     service_start('vdsmd')
Line 39:     start = time.time()
Line 40:     while time.time() - start < wait_secs and service_status('vdsmd'):
Line 41:         time.sleep(1)


http://gerrit.ovirt.org/#/c/25276/9/vdsm/clientIF.py
File vdsm/clientIF.py:

Line 425:                                  ' This should not happen!'
Line 426:                                  ' Will try to recover them.', len(recVms))
Line 427:             for vmId in recVms:
Line 428:                 if not self._recoverVm(vmId):
Line 429:                     self.log.warning('VM %s failed to recover from recovery'
just to doublecheck - VdsUpdateRuntimeInfo does handle correctly when it has VM running on host A and suddenly gets "VM Down" on host B, right? (e.g. in case of crash on src during migration, guest finishes before vdsm restarts)
Line 430:                                      ' file, reported as Down', vmId)
Line 431: 
Line 432:             while (self._enabled and
Line 433:                    vmstatus.WAIT_FOR_LAUNCH in [v.lastStatus for v in


-- 
To view, visit http://gerrit.ovirt.org/25276
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id495f6047ba658c2b04da19bd7bf76425b3b9659
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list