Change in vdsm[master]: bridge_options: Add custom network hook for applying bridge_...

dougsland at redhat.com dougsland at redhat.com
Thu Apr 10 18:22:43 UTC 2014


Douglas Schilling Landgraf has posted comments on this change.

Change subject: bridge_options: Add custom network hook for applying bridge_options
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

kind of trivial but I have comments so -1

http://gerrit.ovirt.org/#/c/26670/1/vdsm_hooks/bridge_options/Makefile.am
File vdsm_hooks/bridge_options/Makefile.am:

Line 1: #
Line 2: # Copyright 2013 Red Hat, Inc.
2014
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
Line 6: # the Free Software Foundation; either version 2 of the License, or


http://gerrit.ovirt.org/#/c/26670/1/vdsm_hooks/bridge_options/bridge_options.py
File vdsm_hooks/bridge_options/bridge_options.py:

Line 21: from vdsm.utils import CommandPath
Line 22: import json
Line 23: import os
Line 24: import sys
Line 25: import hooking
from http://legacy.python.org/dev/peps/pep-0008/#imports:

Imports should be grouped in the following order:
- standard library imports
- related third party imports
- local application/library specific imports

Also put a blank line between each group of imports.
Line 26: import traceback
Line 27: 
Line 28: BRIDGING_OPT_PATH = '/sys/class/net/%s/bridge/%s'
Line 29: EXT_TEE = CommandPath('tee', '/usr/bin/tee')


Line 25: import hooking
Line 26: import traceback
Line 27: 
Line 28: BRIDGING_OPT_PATH = '/sys/class/net/%s/bridge/%s'
Line 29: EXT_TEE = CommandPath('tee', '/usr/bin/tee')
should we use underscore naming for these two constants?
Line 30: 
Line 31: 
Line 32: def test():
Line 33:     def dummy_fwd_delay():


-- 
To view, visit http://gerrit.ovirt.org/26670
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I28424cf036b18afc2c1767d6184cb76f25026d8b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list