Change in vdsm[master]: spec: publish custom network properties

fromani at redhat.com fromani at redhat.com
Thu Apr 10 14:59:10 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: spec: publish custom network properties
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

Looks good to me, just added a suggestion.

http://gerrit.ovirt.org/#/c/26671/1/vdsm_api/vdsmapi-schema.json
File vdsm_api/vdsmapi-schema.json:

Line 166: #
Line 167: # @defaultRoute:  #optional boolean - Is this network's gateway the host's
Line 168: #                 default gateway?
Line 169: #
Line 170: # @custom:        #optional A dictionary of custom, free-form properties for network.
nit/suggestion: I find useful to declare the version on a given field was added to an existing type (e.g. migrationProgress).
Line 171: #
Line 172: # Since: 4.10.0
Line 173: ##
Line 174: {'type': 'SetupNetworkNetAttributes',


-- 
To view, visit http://gerrit.ovirt.org/26671
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8461cf9daea7c4b76cbfde05b8e85aeea4195b2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list