Change in vdsm[master]: packaging: allow to boot VMs from host CD-ROM

sbonazzo at redhat.com sbonazzo at redhat.com
Thu Apr 10 10:03:14 UTC 2014


Sandro Bonazzola has posted comments on this change.

Change subject: packaging: allow to boot VMs from host CD-ROM
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.ovirt.org/#/c/26541/3/vdsm.spec.in
File vdsm.spec.in:

Line 690: 
Line 691: /usr/bin/getent passwd %{vdsm_user} >/dev/null || \
Line 692:     /usr/sbin/useradd -r -u 36 -g %{vdsm_group} -d /var/lib/vdsm \
Line 693:         -s /sbin/nologin -c "Node Virtualization Manager" %{vdsm_user}
Line 694: /usr/sbin/usermod -a -G %{qemu_group},%{snlk_group},%{cdrom_group} %{vdsm_user}
> please verify whether vdsm really needs to read the cdrom content.
without vdsm added hosted-engine deploy fails with 
"Failed to execute stage 'Environment customization': The specified installation media is not readable. Please ensure that /dev/cdrom could be read by vdsm user or kvm group"
Line 695: /usr/sbin/usermod -a -G %{cdrom_group} %{qemu_user}
Line 696: 
Line 697: %post
Line 698: %{_bindir}/vdsm-tool configure --module sanlock --force


Line 691: /usr/bin/getent passwd %{vdsm_user} >/dev/null || \
Line 692:     /usr/sbin/useradd -r -u 36 -g %{vdsm_group} -d /var/lib/vdsm \
Line 693:         -s /sbin/nologin -c "Node Virtualization Manager" %{vdsm_user}
Line 694: /usr/sbin/usermod -a -G %{qemu_group},%{snlk_group},%{cdrom_group} %{vdsm_user}
Line 695: /usr/sbin/usermod -a -G %{cdrom_group} %{qemu_user}
> oh sorry, I now see that this has been ticked as verified. a bit surprising
a bit surprising to me too but selinux labeling seems to be done by libvirt itself before accessing the device as /dev is mounted rw and the device is rw too.
Line 696: 
Line 697: %post
Line 698: %{_bindir}/vdsm-tool configure --module sanlock --force
Line 699: %{_bindir}/vdsm-tool sebool-config || :


-- 
To view, visit http://gerrit.ovirt.org/26541
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I44d842e7b1df073c33284b51185e29ce0d02a0e0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list