Change in vdsm[master]: netlink: User libnl-3 when available

asegurap at redhat.com asegurap at redhat.com
Wed Apr 9 16:20:40 UTC 2014


Antoni Segura Puimedon has posted comments on this change.

Change subject: netlink: User libnl-3 when available
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.ovirt.org/#/c/26514/6/lib/vdsm/netlink.py
File lib/vdsm/netlink.py:

Line 112: @contextmanager
Line 113: def _cache_manager(cache_allocator, sock):
Line 114:     """Provides a cache using cache_allocator and frees it and its links upon
Line 115:     exit."""
Line 116:     cache = cache_allocator(sock)
> why did you remove the raise IOError()? how is it related to this patch?
I did not remove it. I moved it to the cache_allocator methods as per nsoffer's suggestion (see lines 244, 269 and 277)
Line 117:     try:
Line 118:         yield cache
Line 119:     finally:
Line 120:         _nl_cache_free(cache)


-- 
To view, visit http://gerrit.ovirt.org/26514
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I45f043a8416e57d5fb550e2e817e6df38cd793b1
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list