Change in vdsm[master]: vdsm: add support for S3/S4 suspend calls

fromani at redhat.com fromani at redhat.com
Wed Apr 9 12:55:14 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: vdsm: add support for S3/S4 suspend calls
......................................................................


Patch Set 8:

(2 comments)

http://gerrit.ovirt.org/#/c/19389/8/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2304:     def pmWakeup(self):
Line 2305:         self.log.debug('pmWakeup Called')
Line 2306:         hooks.after_vm_dehibernate(self._dom.XMLDesc(0), self.conf)
Line 2307:         try:
Line 2308:             self._dom.pMWakeup()
> libvirt.virDomain has pMWakeup(self, flags) atleast in my version, could yo
yep pMWakeup is correct. Strange naming, but however. problem solved :)
Line 2309:         except:
Line 2310:             self.log.error("pmWakeup failed", exc_info=True)
Line 2311:             return {'status': {'code': errCode['exist']['status']['code'],
Line 2312:                     'message': 'Failed to wake up VM.'}}


Line 2339:             self.log.error("pmSuspend failed", exc_info=True)
Line 2340:             return {'status': {'code': errCode['exist']['status']['code'],
Line 2341:                     'message': 'Failed to suspend VM.'}}
Line 2342:         else:
Line 2343:             # We have to treat hybrid as standard S3
> false, the comment is only to reflect that if hybrid was called, we treat i
OK, fine for me. Maybe then it is a bit clearer if you move the comment down a line so it is near to the if () below.
Line 2344:             self.log.debug('pmSuspend succeeded')
Line 2345:             if target in ('mem', 'hybrid'):
Line 2346:                 self.lastStatus = 'Paused'
Line 2347:                 self.conf['pauseCode'] = targets[target]['reason']


-- 
To view, visit http://gerrit.ovirt.org/19389
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic30016c5cd555f5771dde8db3f1340e1c11b3da7
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list