Change in vdsm[master]: vm: report exit reason for migration failed

danken at redhat.com danken at redhat.com
Tue Apr 8 21:52:00 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: vm: report exit reason for migration failed
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/25164/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 1958: 
Line 1959:             self.recovering = False
Line 1960:             self.saveState()
Line 1961:         except MigrationError as e:
Line 1962:             self.log.exception("The vm start process failed", exc_info=True)
> with log.exception you don't need exc_info
... and "as e" is not needed anyway in this clause.
Line 1963:             self.setDownStatus(ERROR, vmexitreason.MIGRATION_FAILED)
Line 1964:         except Exception as e:
Line 1965:             if self.recovering:
Line 1966:                 self.log.info("Skipping errors on recovery", exc_info=True)


-- 
To view, visit http://gerrit.ovirt.org/25164
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iab6cb810138e751f8fde784c5f6e0fdaf0f51fa2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list