Change in vdsm[master]: vm: avoid to reply with half-baked statistics

fromani at redhat.com fromani at redhat.com
Tue Apr 8 14:27:45 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: vm: avoid to reply with half-baked statistics
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.ovirt.org/#/c/25803/5//COMMIT_MSG
Commit Message:

Line 16: complete statistic sample, or we don't reply at all, and instead
Line 17: we raise an error code.
Line 18: 
Line 19: Change-Id: I65197459cd183af5e7a1634a5ffb01719364a070
Line 20: Bug-Url: https://bugzilla.redhat.com/1073478
> Will amend the commit message with proper and comprehensive explanation.
Dan,

after thinking about your comment and after a review with Michal, turns out this is not the best approach, because this patch ends up stretched between the need to fix the issue reported in the BZ, and the need to *properly* fix and clean this code. I think we can (and should) achieve both.

What I suggest as next move, as explained in greater detail here:
https://lists.fedorahosted.org/pipermail/vdsm-devel/2014-April/003266.html

is a quick fix for 3.5 and maybe 3.4:
http://gerrit.ovirt.org/#/c/26539/

and to restare *in parallel* designing a cleaner fix and a refactoring of this code.

I also took the chance to starting some unit tests here:
http://gerrit.ovirt.org/#/c/26536/


-- 
To view, visit http://gerrit.ovirt.org/25803
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I65197459cd183af5e7a1634a5ffb01719364a070
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jarod.w <work.iec23801 at gmail.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list