Change in vdsm[master]: packaging: add vdsm user to cdrom group

danken at redhat.com danken at redhat.com
Tue Apr 8 11:52:25 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: packaging: add vdsm user to cdrom group
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/26541/1/debian/vdsm.postinst
File debian/vdsm.postinst:

Line 33:             useradd -r -u 36 -g "$VDSM_GROUP" -d /var/lib/vdsm \
Line 34:             -s /usr/sbin/nologin -c "Node Virtualization Manager" "$VDSM_USER"
Line 35:         #getent passwd "$SNLK_USER" >/dev/null || useradd -r -g "$SNLK_GROUP" \
Line 36:         #    -s /bin/false -c "sanlock service" "$SNLK_USER"
Line 37:         usermod -a -G "$QEMU_GROUP","$SNLK_GROUP","$LIBVIRT_SOCK_GROUP" \
I believe groups should be coma-separated.
Line 38:             "$CDROM_GROUP" "$VDSM_USER"
Line 39:         usermod -a -G "$QEMU_GROUP","$VDSM_GROUP" "$SNLK_USER"
Line 40: 
Line 41:         start_conf_section="## beginning of configuration section by vdsm"


-- 
To view, visit http://gerrit.ovirt.org/26541
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I44d842e7b1df073c33284b51185e29ce0d02a0e0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list