Change in vdsm[master]: core: Add boot time to the getVdsStats API
danken at redhat.com
danken at redhat.com
Mon Apr 7 19:42:37 UTC 2014
Dan Kenigsberg has posted comments on this change.
Change subject: core: Add boot time to the getVdsStats API
......................................................................
Patch Set 11:
(1 comment)
http://gerrit.ovirt.org/#/c/25877/11/vdsm/sampling.py
File vdsm/sampling.py:
Line 444: except:
Line 445: if not self._stopEvent.isSet():
Line 446: self._log.error("Error while sampling stats", exc_info=True)
Line 447:
Line 448: @property
> @property is useful when you like to provide nice accesors that do *not* ch
Yes, hiding the implementation (whether it's a method or data member) has benefits - when we expect multiple users or competing implementations. I do not see this reasons apply here.
Line 449: @utils.memoized
Line 450: def _boot_time(self):
Line 451: # Try to get boot time only once, if N/A just log the error and never
Line 452: # include it in the response.
--
To view, visit http://gerrit.ovirt.org/25877
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I319e619cdaecac2f86d0154e3adbb3beda9c57d6
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list