Change in vdsm[master]: gluster: Get size information of a gluster volume.

danken at redhat.com danken at redhat.com
Mon Apr 7 11:24:42 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: gluster: Get size information of a gluster volume.
......................................................................


Patch Set 5: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/26343/5/vdsm/gluster_glfs/Makefile.am
File vdsm/gluster_glfs/Makefile.am:

Line 1: #
Line 2: # Copyright 2014 Red Hat, Inc.
I am not at all happy with adding C code into Vdsm. It seems like a limited form of Python binding for glfs_statvfs. Could this be implemented elsewhere
(such as an independent python-glfs package)?

In any case, it should be declared as such in its own patch and commit message.
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
Line 6: # the Free Software Foundation; either version 2 of the License, or


-- 
To view, visit http://gerrit.ovirt.org/26343
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib628b10c3b9743bb9fef5cbf41195e69ff851efd
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Aravinda VK <avishwan at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list