Change in vdsm[master]: vm: report exit reason for migration failed

fromani at redhat.com fromani at redhat.com
Mon Apr 7 08:31:42 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: vm: report exit reason for migration failed
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/25164/2/vdsm/vm.py
File vdsm/vm.py:

Line 2337:                     pass
Line 2338: 
Line 2339:             self.recovering = False
Line 2340:             self.saveState()
Line 2341:         except MigrationError as e:
> I wonder if we shouldn't review the behavior hereā€¦I don't think we should s
Well, the purpose of this patch is to explicitely detect migration errors by raising a more specific exception, and to fix the exitReason in this case, in order to report a more meaningful information and not just Generic Error.
(for the sake of completeness: migration (errors) and recovery cannot happen at the same time, so the if self.recovering was stripped).

That said, I think Michal's point is still valid and I'll double'check this scenario.
Line 2342:             self.log.error("The vm start process failed", exc_info=True)
Line 2343:             self.setDownStatus(ERROR, vmexitreason.MIGRATION_FAILED)
Line 2344:         except Exception as e:
Line 2345:             if self.recovering:


-- 
To view, visit http://gerrit.ovirt.org/25164
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iab6cb810138e751f8fde784c5f6e0fdaf0f51fa2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list