Change in vdsm[master]: sd: improve metadata sizes definition

danken at redhat.com danken at redhat.com
Fri Apr 4 22:43:06 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: sd: improve metadata sizes definition
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/26412/2/vdsm/storage/sd.py
File vdsm/storage/sd.py:

Line 54: IDS = "ids"
Line 55: INBOX = "inbox"
Line 56: OUTBOX = "outbox"
Line 57: 
Line 58: METADATA_SIZEMB = {
overpedantic: it's MiB, not MB.

I find the name of the dictionary a bit odd, since these special volumes are exactly "metadata". How about SPECIAL_VOLUME_SIZES_MIB ?
Line 59:     LEASES: 2048,
Line 60:     IDS: 8,
Line 61:     INBOX: 16,
Line 62:     OUTBOX: 16,


-- 
To view, visit http://gerrit.ovirt.org/26412
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0fe1381ed0883194e283e457e3c948159c68c01d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list