Change in vdsm[master]: vm: handle missing domains on recovery

danken at redhat.com danken at redhat.com
Fri Apr 4 11:50:06 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: vm: handle missing domains on recovery
......................................................................


Patch Set 5: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/25275/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 1969:             self.saveState()
Line 1970:         except MissingLibvirtDomainError:
Line 1971:             self.recovering = False
Line 1972:             # we cannot ever deal with this, not even on recovery.
Line 1973:             self.setDownStatus(ERROR, vmexitreason.LIBVIRT_DOMAIN_MISSING)
If a VM was already Down before Vdsm was restarted, it has another existreason which should not be hidden. One of the motivations for the follow-up patch is not to loose to original exitreason, and have it collected properly by Engine.
Line 1974:         except Exception as e:
Line 1975:             if self.recovering:
Line 1976:                 self.log.info("Skipping errors on recovery", exc_info=True)
Line 1977:             else:


-- 
To view, visit http://gerrit.ovirt.org/25275
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I00ef12883c8035209de0f273925eb8603d6b6da8
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list