Change in vdsm[master]: hook: spiceoptions: To provide spice option attributes to vm
apahim at redhat.com
apahim at redhat.com
Fri Apr 4 10:54:02 UTC 2014
Amador Pahim has posted comments on this change.
Change subject: hook: spiceoptions: To provide spice option attributes to vm
......................................................................
Patch Set 7:
(4 comments)
http://gerrit.ovirt.org/#/c/22178/7/vdsm_hooks/spiceoptions/before_vm_start.py
File vdsm_hooks/spiceoptions/before_vm_start.py:
Line 10:
Line 11: '''
Line 12: Hook to configure spice options on a vm
Line 13:
Line 14: For ex:
> IMO redundant
Done
Line 15:
Line 16: Syntax:
Line 17: spiceoptions={'element': {'attribute': 'value'},..
Line 18:
Line 15:
Line 16: Syntax:
Line 17: spiceoptions={'element': {'attribute': 'value'},..
Line 18:
Line 19: For ex:
> No need of shortening here:
Done
Line 20: spiceoptions={'image': {'compression': 'auto_glz'},
Line 21: 'jpeg': {'compression': 'never'},
Line 22: 'streaming':{'mode':'filter'}}
Line 23:
Line 60: domxml = hooking.read_domxml()
Line 61: for graphDev in domxml.getElementsByTagName('graphics'):
Line 62: if graphDev.getAttribute('type') == 'spice':
Line 63: for elmt, value in spiceConfig.items():
Line 64: if elmt not in spiceOpts.keys():
> please use
Done
Line 65: sys.stderr.write(" Invalid ELEMENT"
Line 66: " [%s] " % elmt)
Line 67: else:
Line 68: for attr, attrValue in value.items():
Line 65: sys.stderr.write(" Invalid ELEMENT"
Line 66: " [%s] " % elmt)
Line 67: else:
Line 68: for attr, attrValue in value.items():
Line 69: if attr not in spiceOpts[elmt].keys():
> same here:
Done
Line 70: sys.stderr.write(" Invalid ATTRIBUTE"
Line 71: " [%s]" % attr)
Line 72: elif attrValue not in spiceOpts[elmt][attr]:
Line 73: sys.stderr.write(" Invalid VALUE"
--
To view, visit http://gerrit.ovirt.org/22178
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7761aab98cdc3a0d37bed7984ae540278e6bbf70
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Humble Devassy Chirammal <hchiramm at redhat.com>
Gerrit-Reviewer: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Humble Devassy Chirammal <hchiramm at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list