Change in vdsm[master]: recovery: clean the VM recovery procedure

asegurap at redhat.com asegurap at redhat.com
Fri Apr 4 10:39:02 UTC 2014


Antoni Segura Puimedon has posted comments on this change.

Change subject: recovery: clean the VM recovery procedure
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/26426/1/vdsm/clientIF.py
File vdsm/clientIF.py:

Line 488:                     self.log.error("Can't look for domId: %s, code: %s",
Line 489:                                    domId, e.get_error_code(), exc_info=True)
Line 490:                     raise
Line 491:             else:
Line 492:                 if self.isVDSMVm(vm):
why not elif?
Line 493:                     vms.append(vm)
Line 494:         return vms
Line 495: 
Line 496:     def _recoverVm(self, vmid):


-- 
To view, visit http://gerrit.ovirt.org/26426
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idf09400276d9fcf24a0ad6673ee1d12f19a92195
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list