Change in vdsm[ovirt-3.3]: clientIF: Rescan devices if device not found after vmHotplug...

danken at redhat.com danken at redhat.com
Thu Apr 3 17:43:09 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: clientIF: Rescan devices if device not found after vmHotplugDisk
......................................................................


clientIF: Rescan devices if device not found after vmHotplugDisk

According to the analysis in the bug, invoking vmHotplugDisk right after
connectStorageServer may not leave enough time for multipathd to create
the device, leading to unnecessary failure.

As I understand, multipathd is receiving events from udev and creating
devices. The race is probably related to the asynchronous nature of this
mechanism. Invoking multipath.rescan() force synchronous update of the
found devices.

The original fix in commit 15c7f74365cb5d2c9258bc333c441941c6e42bdb
tried to to invoke multipath.rescan() if the device was not found. Due
to a unfortunate error, multipath.rescan() was never invoked.  Although
the bug was never fixed, QE verified it and customers are using this
code for the last 6 month.  We believe that the problem is a tiny race
that is unlikely to happen, but it is possible and should be fixed.

This patch implements the original fix in a different way, calling
getDevicesVisibility(), which invokes multipath.rescan() if a device is
missing.

Change-Id: I3d75ac53ca809b7a25d7fb237ec661dd865e31fc
Relates-To: https://bugzilla.redhat.com/923773
Bug-Url: https://bugzilla.redhat.com/1066413
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/21181
Reviewed-by: Ayal Baron <abaron at redhat.com>
Reviewed-by: Allon Mureinik <amureini at redhat.com>
Reviewed-by: Federico Simoncelli <fsimonce at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/25243
---
M vdsm/clientIF.py
1 file changed, 4 insertions(+), 3 deletions(-)

Approvals:
  Nir Soffer: Verified
  Federico Simoncelli: Looks good to me, approved
  Allon Mureinik: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/25243
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3d75ac53ca809b7a25d7fb237ec661dd865e31fc
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list