Change in vdsm[master]: vdsm: add support for hostdev passthrough

dougsland at redhat.com dougsland at redhat.com
Thu Apr 3 15:50:41 UTC 2014


Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm: add support for hostdev passthrough
......................................................................


Patch Set 7: Code-Review-1

(1 comment)

-1 since I have a question.

http://gerrit.ovirt.org/#/c/22462/7/tests/functional/virtTests.py
File tests/functional/virtTests.py:

Line 208:                          'vmName': 'testVmWithHostdev', 'devices':
Line 209:                          [hostdev]}
Line 210: 
Line 211:         with RunningVm(self.vdsm, customization) as vm:
Line 212:             self._waitForStartup(vm, 10)
I would use targetUptime=10 just as clarification what's 10 is about.
or declare a constant as we alrady have VM_MINIMAL_UPTIME. Can we use VM_MINIMAL_UPTIME ?
Line 213: 
Line 214:             status, msg, stats = self.vdsm.getVmList(vm)
Line 215:             self.assertEqual(status, SUCCESS, msg)
Line 216:             exists = False


-- 
To view, visit http://gerrit.ovirt.org/22462
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I363d2622d72ca2db75f60032fe0892c348bab121
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list