Change in vdsm[master]: virt: Move all guest agents related cleanup together

michal.skrivanek at redhat.com michal.skrivanek at redhat.com
Thu Apr 3 11:44:28 UTC 2014


Michal Skrivanek has posted comments on this change.

Change subject: virt: Move all guest agents related cleanup together
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/26280/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2786:         except Exception:
Line 2787:             pass
Line 2788: 
Line 2789:         self._guestSockCleanup(self._guestSocketFile)
Line 2790:         self._guestSockCleanup(self._qemuguestSocketFile)
> That awful "except Exception" stems from an old decision about destroy() ha
then it makes sense to put the gestSockCleanup into the same block...
Line 2791: 
Line 2792:     def setDownStatus(self, code, exitReasonCode, exitMessage=''):
Line 2793:         if not exitMessage:
Line 2794:             exitMessage = vmexitreason.exitReasons.get(exitReasonCode,


-- 
To view, visit http://gerrit.ovirt.org/26280
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I99da4b5b9dcb160974205ebbb3c6d6727415e617
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list