Change in vdsm[master]: core: Add boot time to the getVdsStats API
nsoffer at redhat.com
nsoffer at redhat.com
Thu Apr 3 06:04:13 UTC 2014
Nir Soffer has posted comments on this change.
Change subject: core: Add boot time to the getVdsStats API
......................................................................
Patch Set 11:
(1 comment)
http://gerrit.ovirt.org/#/c/25877/11//COMMIT_MSG
Commit Message:
Line 5: CommitDate: 2014-04-02 16:18:47 +0300
Line 6:
Line 7: core: Add boot time to the getVdsStats API
Line 8:
Line 9: Read boot time from /proc/stat and report in host stats
Why add a constant string (boot time never changes) in a response about statistics? This made sense when we were returning the uptime, but not for boot time.
It seems that this value should returned in a request that is done once, like getVdsCaps. This will also remove the need for caching this value, so we can drop half of the ocde.
Line 10:
Line 11: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1070348
Line 12: Change-Id: I319e619cdaecac2f86d0154e3adbb3beda9c57d6
--
To view, visit http://gerrit.ovirt.org/25877
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I319e619cdaecac2f86d0154e3adbb3beda9c57d6
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list