Change in vdsm[master]: hooks: Add hook for fake VM stats

vfeenstr at redhat.com vfeenstr at redhat.com
Wed Apr 2 12:18:45 UTC 2014


Vinzenz Feenstra has posted comments on this change.

Change subject: hooks: Add hook for fake VM stats
......................................................................


Patch Set 10: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/25927/10/vdsm/hooking.py
File vdsm/hooking.py:

Line 56: def write_domxml(domxml):
Line 57:     file(os.environ['_hook_domxml'], 'w').write(domxml.toxml(encoding='utf-8'))
Line 58: 
Line 59: 
Line 60: def read_json():
> I have mixed feelings about adding these two methods in this change. They m
True, this should be a separate patch
Line 61:     return json.loads(file(os.environ['_hook_json']).read())
Line 62: 
Line 63: 
Line 64: def write_json(data):


-- 
To view, visit http://gerrit.ovirt.org/25927
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a6d13f43495170a5cb86ae0b0efc1ae85ef05ab
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list