Change in vdsm[master]: core: fixing attribute error on fenceSpmStorage

Federico Simoncelli fsimonce at redhat.com
Wed Apr 2 12:12:21 UTC 2014


Federico Simoncelli has posted comments on this change.

Change subject: core: fixing attribute error on fenceSpmStorage
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/26358/1/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:

Line 3531:         pool = self.getPool(spUUID)
Line 3532:         if isinstance(pool.getBackend(), StoragePoolDiskBackend):
Line 3533:             pool.getBackend().invalidateMetadata()
Line 3534:         vars.task.getExclusiveLock(STORAGE, spUUID)
Line 3535:         pool.forceFreeSpm()
Also forceFreeSpm is also relevant only for StoragePoolDiskBackend.
Line 3536:         return dict(spm_st=self._getSpmStatusInfo(pool))
Line 3537: 
Line 3538:     @public
Line 3539:     def upgradeStoragePool(self, spUUID, targetDomVersion):


-- 
To view, visit http://gerrit.ovirt.org/26358
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5ae4c371e2dc97686621ea16b8cef971183a6ab2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list