Change in vdsm[master]: Avoid redundant volume produces.

Federico Simoncelli fsimonce at redhat.com
Wed Apr 2 11:35:39 UTC 2014


Federico Simoncelli has posted comments on this change.

Change subject: Avoid redundant volume produces.
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/17991/1/vdsm/storage/sd.py
File vdsm/storage/sd.py:

Line 640:         # If it has a repo we don't have multiple domains. Assume single pool
Line 641:         return os.path.join(self.storage_repository, self.getPools()[0])
Line 642: 
Line 643:     def getVolumePath(self, imgUUID, volUUID):
Line 644:         return os.path.join(self.mountpoint, self.sdUUID, 'images', imgUUID,
Use DOMAIN_IMAGES instead of 'images'. Also this getVolumePath looks different from the previous vol.getVolumePath since it reaches the volume through the mountpoint instead that through the storage pool directory.
Line 645:                             volUUID)
Line 646: 
Line 647:     def getIsoDomainImagesDir(self):
Line 648:         """


-- 
To view, visit http://gerrit.ovirt.org/17991
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3ad53a7e8a66d7f9bdd62048f2bf1f722a490c5c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Elad Ben Aharon <eladba1990 at gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list