Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults

danken at redhat.com danken at redhat.com
Tue Apr 1 22:43:10 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: netinfo: Retrieve bonding options differing from defaults
......................................................................


Patch Set 20: Code-Review-1

(2 comments)

http://gerrit.ovirt.org/#/c/24456/20/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:

Line 534:     return ''.join(random.choice(CHARS) for _ in range(MAX_LENGTH))
Line 535: 
Line 536: 
Line 537: @memoized
Line 538: def _getDefaultBondingOptions():
please document the two-level dictionary returned here
Line 539:     teeCmd = _TEE_BINARY.cmd
Line 540:     MAX_MODE = 6
Line 541: 
Line 542:     bondName = _randomIfaceName()


Line 569: def _getBondingOptions(bond):
Line 570:     '''
Line 571:     Returns non-empty options differing from defaults, excluding e.g. 'slaves'.
Line 572: 
Line 573:     A string key=value representation (as in ifcfg) is also returned for
A function should do one thing. Please split the dict-to-legacy conversion to another helper function.
Line 574:     backwards compatibility reasons.
Line 575:     '''
Line 576:     EXCLUDED = frozenset(('slaves', 'active_slave', 'mii_status', 'queue_id'))
Line 577: 


-- 
To view, visit http://gerrit.ovirt.org/24456
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list