Change in vdsm[master]: virt: migration: use contextmanager for monitor

asegurap at redhat.com asegurap at redhat.com
Tue Apr 1 07:31:09 UTC 2014


Antoni Segura Puimedon has posted comments on this change.

Change subject: virt: migration: use contextmanager for monitor
......................................................................


Patch Set 12: Code-Review+1

(1 comment)

I really, really like this patch!

http://gerrit.ovirt.org/#/c/25978/12/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 332:                     raise
Line 333: 
Line 334: 
Line 335: @contextmanager
Line 336: def migrationMonitor(vm, startTime, downTime):
what about just "monitor" so that we have, in line 297, "with monitor(..."
Line 337:     monitorThread = MonitorThread(vm, startTime, downTime)
Line 338:     monitorThread.start()
Line 339:     try:
Line 340:         yield monitorThread


-- 
To view, visit http://gerrit.ovirt.org/25978
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7fcd0bedf4f30cc0bcab03339322df1fc5434e8
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list