Change in vdsm[master]: Make vdsm-tool dynamic module loading take the package name ...

danken at redhat.com danken at redhat.com
Thu Oct 31 22:15:39 UTC 2013


Dan Kenigsberg has submitted this change and it was merged.

Change subject: Make vdsm-tool dynamic module loading take the package name into account
......................................................................


Make vdsm-tool dynamic module loading take the package name into account

According to the imp.load_module API documentation:
    http://docs.python.org/2/library/imp.html#imp.load_module
the name that is passed as a first parameter should be the full
module name, i.e., including the package name. Without the package
name, relative imports and future proofing of the module are not
possible.

Change-Id: I432d2f31f5e9f58c942a2cca334ca4bc39995c7d
Signed-off-by: Antoni S. Puimedon <asegurap at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/20762
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm-tool/vdsm-tool
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Antoni Segura Puimedon: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/20762
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I432d2f31f5e9f58c942a2cca334ca4bc39995c7d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list