Change in vdsm[master]: Introducing configurator package in vdsm-tool

ybronhei at redhat.com ybronhei at redhat.com
Thu Oct 31 14:46:23 UTC 2013


Yaniv Bronhaim has posted comments on this change.

Change subject: Introducing configurator package in vdsm-tool
......................................................................


Patch Set 19:

(1 comment)

....................................................
File lib/vdsm/tool/configurator.py
Line 172:     services_to_stop = []
Line 173:     for m in args.modules:
Line 174:         if m.getName() not in __configurers:
Line 175:             raise RuntimeError("Module %s does not exists")
Line 176:         if not __configurers[m].isconfigured():
but this means that if the validation doesn't pass you won't be able to configure for good. it'll always fail in this stage
Line 177:             services_to_stop.append(m.getServiceName())
Line 178:             services_to_stop.append(m.getDependedServicesList())
Line 179: 
Line 180:     service_to_start = []


-- 
To view, visit http://gerrit.ovirt.org/20100
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I16bf5894e7e55a84b4c2a0caacde383ae7c19242
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list