Change in vdsm[master]: Invalidate filters on HSMs before rescanning extended VG

sgotliv at redhat.com sgotliv at redhat.com
Thu Oct 31 07:22:06 UTC 2013


Sergey Gotliv has posted comments on this change.

Change subject: Invalidate filters  on HSMs before rescanning extended VG
......................................................................


Patch Set 16:

(1 comment)

....................................................
File vdsm/storage/hsm.py
Line 2004:                   boolean
Line 2005:         :rtype: dict
Line 2006:         """
Line 2007:         visibility = self.scanDevicesVisibility(guids)
Line 2008:         lvm.invalidateFilter()
Just to be clear, it can move to scanDevicesVisibility either but not into the "if" there.
Line 2009:         for guid in guids:
Line 2010:             if visibility[guid]:
Line 2011:                 visibility[guid] = (os.stat('/dev/mapper/' + guid).st_mode &
Line 2012:                                     stat.S_IRUSR != 0)


-- 
To view, visit http://gerrit.ovirt.org/20552
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If1eeed1c203f2c8c73370987048565d665932299
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pavel Zhukov <pzhukov at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Lee Yarwood <lyarwood at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Pavel Zhukov <pzhukov at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Tomáš Došek <tdosek at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list