Change in vdsm[master]: gluster: performs peer detach using host UUID if provided
avishwan at redhat.com
avishwan at redhat.com
Thu Oct 31 06:28:53 UTC 2013
Aravinda VK has posted comments on this change.
Change subject: gluster: performs peer detach using host UUID if provided
......................................................................
Patch Set 1:
(1 comment)
....................................................
File vdsm/gluster/api.py
Line 213:
Line 214: @exportAsVerb
Line 215: def hostRemove(self, hostName, force=False, options={}):
Line 216: host = None
Line 217: hostUuid = options.get('hostUuid')
One more option. how about using UUID validation to decide input value.
hostUuid = ""
try:
hostUuid = str(uuid.UUID(hostName))
except ValueError:
pass
This eliminates modification to existing function signature.
Line 218:
Line 219: # get hostname of given host uuid
Line 220: if hostUuid:
Line 221: for hostInfo in self.svdsmProxy.glusterPeerStatus():
--
To view, visit http://gerrit.ovirt.org/20648
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idfff258ccc43c276ca7b9c0472dacac2fefce64a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Aravinda VK <avishwan at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list